Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSP-634 Change lan and usb address fields to have a generic name #12

Merged
merged 3 commits into from
May 22, 2024
Merged

TSP-634 Change lan and usb address fields to have a generic name #12

merged 3 commits into from
May 22, 2024

Conversation

Shreya-GT
Copy link
Contributor

No description provided.

@Shreya-GT Shreya-GT added the bug Something isn't working label May 20, 2024
@Shreya-GT Shreya-GT requested review from esarver and nazanjaffery May 20, 2024 07:32
@Shreya-GT Shreya-GT self-assigned this May 20, 2024
@Shreya-GT Shreya-GT requested a review from a team as a code owner May 20, 2024 07:32
@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

Code Coverage

Package Line Rate Health
kic-discover/src/lib.rs 0% ❌
kic/src/main.rs 0% ❌
kic-discover/src/instrument_discovery/mod.rs 0% ❌
instrument-repl/src/resources/mod.rs 100% ✔
instrument-repl/src/instrument.rs 86% ✔
kic-discover/src/usbtmc/mod.rs 0% ❌
kic-discover/src/ethernet/mod.rs 0% ❌
instrument-repl/src/state_machine.rs 63% ✔
kic/src/process.rs 0% ❌
instrument-repl/src/tsp_error.rs 0% ❌
instrument-repl/src/error.rs 0% ❌
kic-discover/src/main.rs 0% ❌
instrument-repl/src/repl.rs 0% ❌
kic/src/error.rs 0% ❌
Summary 16% (295 / 1790) ❌

nazanjaffery
nazanjaffery previously approved these changes May 21, 2024
View reviewed changes
@Shreya-GT Shreya-GT requested a review from jharajeev55 May 22, 2024 07:41
@Shreya-GT Shreya-GT merged commit d90ae6e into main May 22, 2024
10 checks passed
@Shreya-GT Shreya-GT deleted the bug_fix/TSP-634-Fix-instr-addr-change-issue branch May 22, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharajeev55 jharajeev55 jharajeev55 approved these changes

@nazanjaffery nazanjaffery nazanjaffery left review comments

@esarver esarver Awaiting requested review from esarver

Assignees

@Shreya-GT Shreya-GT

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shreya-GT @jharajeev55 @nazanjaffery